feature: summarizable associations #3428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit b3f357b and detected 0 issues on this pull request. View more on Code Climate. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thiagoyoussef
force-pushed
the
feature/summarizable-associations
branch
from
0036e9c
to
26835c0
Compare
Paul-Bob
requested changes
Nov 19, 2024
Paul-Bob
reviewed
Nov 19, 2024
Comment on lines
+17
to
+19
| query = resource.authorization&.apply_policy related_records | ||
|
|
||
| Avo::ExecutionContext.new(target: resource.search_query, query: query).handle |
There was a problem hiding this comment.
Suggested change
| query = resource.authorization&.apply_policy related_records | |
| Avo::ExecutionContext.new(target: resource.search_query, query: query).handle | |
| related_records |
Comment on lines
+25
to
+32
| def related_records | ||
| relation_class = BaseResource.get_model_by_name(params[:via_relation_class]) | ||
| parent = relation_class.find(params[:via_record_id]) | ||
|
|
||
| association_name = BaseResource.valid_association_name(parent, resource.model_key) | ||
|
|
||
| parent.send(association_name) | ||
| end |
There was a problem hiding this comment.
Suggested change
| def related_records | |
| relation_class = BaseResource.get_model_by_name(params[:via_relation_class]) | |
| parent = relation_class.find(params[:via_record_id]) | |
| association_name = BaseResource.valid_association_name(parent, resource.model_key) | |
| parent.send(association_name) | |
| end | |
| def related_records | |
| relation_class = BaseResource.get_model_by_name(params[:via_relation_class]) | |
| parent = relation_class.find(params[:via_record_id]) | |
| association_name = BaseResource.valid_association_name(parent, resource.model_key) | |
| parent_resource = ... | |
| association_field = ... | |
| query = resource.authorization.apply_policy parent.send(association_name) | |
| Avo::ExecutionContext.new( | |
| target: association_field.scope, | |
| query: query, | |
| parent: parent, | |
| resource: resource, | |
| parent_resource: parent_resource | |
| ).handle | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2993
Checklist:
Screenshots & recording